Skip to content

Conversation

@jonathoncove2
Copy link
Contributor

Description

Added a brief example on adding messages to a notification

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • [ x] New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

v10

Deadline (if relevant)

N/A

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jonathoncove2 !

I've made some tiny suggestions. Let me know if something doesn't look right.

@jonathoncove2
Copy link
Contributor Author

jonathoncove2 commented Nov 1, 2024

Thanks for the tweaks! All looks good to me

@sofietoft
Copy link
Contributor

Thanks for considering the suggestions @jonathoncove2 ! 💪

Would it make sense to add a little more context to this code sample?
Like, in which file would this code go, and when would you normally use this kind of notification? 🤔

@sofietoft
Copy link
Contributor

Hi @jonathoncove2 !

Did you see my previous message? 😄

Added a better explanation of when to use the code
@jonathoncove2
Copy link
Contributor Author

Apologies @sofietoft , I've made some edits now which give some more detail. Likely needs umbraco-ifying a bit

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @jonathoncove2 ! 😄 Thanks.

I've made a suggestion - should shorten the sentence, but let me know if you think it still makes sense!

@sofietoft
Copy link
Contributor

Thanks for considering the suggestion @jonathoncove2 ! 😄

Looks like we're ready to merge this one.
I'll do so, once the checks complete.

@sofietoft sofietoft merged commit a759772 into umbraco:main Dec 2, 2024
41 of 65 checks passed
@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @jonathoncove2!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

@nul800sebastiaan
Copy link
Member

@jonathoncove2 Good day! You still have a few days to let us know what you want for Hacktoberfest 🎁, we'd love it if it was an active choice!
If you just want us to plant trees 🌳 then let me know or give the form a quick fill (only 2 fields to fill in for trees).
https://feedback.umbraco.com/umbraco-hacktoberfest-2024/

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants